Skip to content

chore(empty-outlet): remove unnecessary moduleId #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

chore(empty-outlet): remove unnecessary moduleId #1686

merged 1 commit into from
Jan 4, 2019

Conversation

ADjenkov
Copy link
Contributor

@ADjenkov ADjenkov commented Jan 4, 2019

No description provided.

@ADjenkov ADjenkov self-assigned this Jan 4, 2019
@ADjenkov ADjenkov requested a review from sis0k0 January 4, 2019 08:53
@ghost ghost added the in progress label Jan 4, 2019
@sis0k0
Copy link
Contributor

sis0k0 commented Jan 4, 2019

fixes NativeScript/nativescript-sdk-examples-ng#347

@ADjenkov ADjenkov merged commit 2562836 into master Jan 4, 2019
@ghost ghost removed the in progress label Jan 4, 2019
@ADjenkov ADjenkov deleted the djenkov/empty-outlet-module-id branch January 4, 2019 14:17
This was referenced Jan 9, 2019
Closed
Closed
SvetoslavTsenov pushed a commit that referenced this pull request Jan 21, 2019
@ADjenkov @SvetoslavTsenov
chore(empty-outlet): remove unnecessary moduleId (#1686)
742d94e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtopuzov dtopuzov dtopuzov approved these changes

@sis0k0 sis0k0 sis0k0 approved these changes

Assignees

@ADjenkov ADjenkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ADjenkov @sis0k0 @dtopuzov